| Title: | USG buildhelp questions/answers |
| Moderator: | SMURF::FILTER |
| Created: | Mon Apr 26 1993 |
| Last Modified: | Mon Jan 20 1997 |
| Last Successful Update: | Fri Jun 06 1997 |
| Number of topics: | 2763 |
| Total number of notes: | 5802 |
Date Of Receipt: 15-NOV-1996 16:31:19.08
From: FLUME::"[email protected]" "15-Nov-1996 1629"
To: [email protected], [email protected], [email protected]
CC: [email protected], [email protected]
Subj: Thought I'd throw this question your way.
------- Forwarded Message
Return-Path: [email protected]
Delivery-Date: Fri, 15 Nov 96 16:23:21 -0500
Return-Path: [email protected]
Received: from ralpha.zk3.dec.com by cardinal.zk3.dec.com
(5.65v3.2/1.1.10.5/27Mar96-1222PM)
id AA31126; Fri, 15 Nov 1996 16:23:20 -0500
Received: from pannik.zk3.dec.com by alpha.zk3.dec.com;
(5.65v3.2/1.1.8.2/20May95-1022AM)
id AA07623; Fri, 15 Nov 1996 16:22:57 -0500
Received: from localhost by pannik.zk3.dec.com; (5.65v3.2/1.1.8.2/02Jul96-0212P
M)
id AA05478; Fri, 15 Nov 1996 16:21:32 -0500
Message-Id: <[email protected]>
To: [email protected]
Cc: [email protected]
Subject: v40asupportos-31-spear
Date: Fri, 15 Nov 96 16:21:32 -0500
From: [email protected]
X-Mts: smtp
For what it's worth,
in v40asupportos-31-spear, I made a mistake that was
not caught by the compiler in the ode environment.
I missed a ; in some code added by me.
The module built w/o failure, the pool built and the
module tested ok.
I've since corrected it and resubmitted using this same srequest.
Anybody care to comment?
*** 1136,1141 ****
- --- 1141,1154 ----
m->m_len += hlen;
m->m_data -= hlen;
m->m_pkthdr.len = next;
+ /* Fix for WNT/Win95 remote ping panic */
+ if( next > (IP_MAXPACKET-hlen)) {
+ NETSTAT_LOCK(&ipstat.ips_lock);
+ ipstat.ips_badlen++ <-----missed it right here!!
+ NETSTAT_UNLOCK(&ipstat.ips_lock);
+ m_freem(m);
+ return (0);
+ }
return m;
dropfrag:
diff -c -r4.4.72.2 OdeSrvrTmpBob_Spear016079/ip_input.c
------- End of Forwarded Message
--
-Grant
| T.R | Title | User | Personal Name | Date | Lines |
|---|---|---|---|---|---|
| 2676.1 | Re: Thought I d throw this question your way. | AOSG::FILTER | Automatic Posting Software - mail to flume::puck | Fri Nov 15 1996 17:19 | 37 |
Date Of Receipt: 15-NOV-1996 16:50:40.11 From: FLUME::"[email protected]" "Craig Neth USG 15-Nov-1996 1647" To: [email protected] CC: [email protected], [email protected], [email protected], [email protected], [email protected] Subj: Re: Thought I'd throw this question your way. > Anybody care to comment? > >+ ipstat.ips_badlen++ <-----missed it right here!! >+ NETSTAT_UNLOCK(&ipstat.ips_lock); I don't know much about this code, but when I look in net_globals.h, I see that NETSTAT_UNLOCK has two definitions: #if LOCK_NETSTATS #define NETSTAT_LOCKINIT(lockp, lip) simple_lock_setup(lockp, lip) #define NETSTAT_LOCK(lockp) simple_lock(lockp) #define NETSTAT_UNLOCK(lockp) simple_unlock(lockp) #else #define NETSTAT_LOCKINIT(lockp, lip) #define NETSTAT_LOCK(lockp) #define NETSTAT_UNLOCK(lockp) #endif My guess is that LOCK_NETSTATS was not defined, and so the expansion of the above code was: ipstat.ips_badlen++ ; Craig | |||||